FIX Run ANALYZE TABLE before fetching table stats #11334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 13, 2024
| $this->withTransaction($fn); | ||
| } else { | ||
| $fn(); | ||
| $this->query("DELETE FROM \"$table\""); |
There was a problem hiding this comment.
Need to keep the comment about not using truncate
GuySartorelli
requested changes
Aug 13, 2024
There was a problem hiding this comment.
Forgot to hit add to review on the above comment, and GitHub doesn't let me not have a comment when I request changes so I have to make a comment even though there's already one and all I want to do is set the status of the PR to reflect the fact that I've requested changes.
emteknetnz
force-pushed
the
pulls/5.2/analyze-table
branch
from
1580e7f to
25a41de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#290
Replaces #11333
Tested on elemental + asset-admin