Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Fix unit test #11438

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tests/php/Security/VersionedMemberAuthenticatorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,14 @@ protected function setUp(): void
return;
}

// Explicity add the Versioned extension to Member, even though it's already in $required_extensions.
// This is done to call `unset(self::class::$extra_methods[strtolower($subclass)]);` in
// Extensible::add_extension() so when CustomMethods::getExtraMethodConfig() updates the $extra_methods
// it will include methods of Versioned such as publishSingle()
// This issue will only occur when running subsequent unit test classes in the same process, rather than this
// this unit test class in isolation
Member::add_extension(Versioned::class);

// Enforce dummy validation (this can otherwise be influenced by recipe config)
PasswordValidator::singleton()
->setMinLength(0)
Expand Down