FIX Allow __call() to trigger __call() in other classes #11487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a class wraps another class, it may rely on calling methods in that other class. If that throws BadMethodCallException we should swallow that in ViewLayerData because it's the same as the method not existing on the object we're directly calling it on.
|
The |
emteknetnz
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/silverstripe/silverstripe-elemental/actions/runs/12128337221/job/33818161207 and many of the failures in https://github.com/silverstripe/silverstripe-cms/actions/runs/12128338043/
Basically
VirtualPagecouldn't be viewed at all, so that's easy to test.If a class wraps another class, it may rely on calling methods in that other class. If that throws BadMethodCallException we should swallow that in ViewLayerData because it's the same as the method not existing on the object we're directly calling it on.
Issue