DEP Require psr/http-message ^2.0 #11505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
emteknetnz
force-pushed
the
pulls/6.0/major-dep
branch
from
3f0f3bc to
9dde201
Compare
|
Is the mock stuff related? There's no information here other than the commit message saying you're updating a dependency, which at face value doesn't seem related to those changes. |
|
The mock stuff needed to be updated because they implement interfaces in psr/http-message, and need to match the new signatures |
|
What uses this mock stuff? Is there an easy thing I can test locally? This isn't code I'm familiar with so some hand-holding is unfortunately needed here. |
|
EmbedUnitTest, I don't think anything else does |
GuySartorelli
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#306