FIX Treat value not in SingleSelectField options as blank #11510
+62
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 12, 2024
Closed
This makes the react dropdown fields behave more like the entwine ones when the DB value is not in the set of dropdown options.
GuySartorelli
force-pushed
the
pulls/5.3/singleselect-no-value
branch
from
0e7a043 to
f5a68ca
Compare
emteknetnz
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces silverstripe/silverstripe-admin#1872
This makes the react dropdown fields behave more like the entwine ones when the DB value is not in the set of dropdown options.
Note that the reproduction steps in the issue rely on the DB field being
Int(or perhaps other numeric fields as well - but specifically not a string type). This is because its default value is0, while the default forVarcharfor example isnullwhich wouldn't exhibit the bug.Issue