Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Convert::raw2filename #7347

Closed

Conversation

wernerkrauss
Copy link
Contributor

This might be a handy shortcut for sanitising a filename.

See silverstripe/silverstripe-errorpage#8
See silverstripe/silverstripe-subsites#299

@dhensby
Copy link
Contributor

dhensby commented Sep 6, 2017

So we are replacing FileNameFilter::create()->filter($f) with Convert::raw2filename($f)?

I'm not sure there's a big incentive for this

@tractorcow
Copy link
Contributor

Thanks for the suggestion, but I don't think the additional reference is necessary for this functionality.

@wernerkrauss
Copy link
Contributor Author

@dhensby it's a similar shortcut like Convert::raw2url(), which ishandy and easier to find for new developers.

@tractorcow
Copy link
Contributor

Sorry it looks like there isn't enough core member support for this feature.

@tractorcow tractorcow closed this Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants