Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Move password complexity requirements into framework #8587

Merged

Conversation

robbieaverill
Copy link
Contributor

The contents of this file are not extensible, so I'm proposing we move it into framework YAML config

Issue: silverstripe/cwp-core#52

Requires recipe-core: silverstripe/recipe-core#34

@kinglozzer
Copy link
Member

I think we originally introduced this in the recipe so it wouldn’t affect existing projects, is storing it in YAML in the recipe an option?

@robbieaverill
Copy link
Contributor Author

robbieaverill commented Nov 8, 2018

Sort of:

  • Yes, it can be in a YAML file
  • The name for it could be #mypasswords
  • Module code can't reliably say it wants to run after this

We could add After: '*' but we've had problems with that in the past. It would also negate the point of having user code if it wasn't honoured.

@bergice bergice merged commit d2cc773 into silverstripe:4.3 Nov 13, 2018
@robbieaverill robbieaverill deleted the pulls/4.3/password-requirements branch November 13, 2018 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants