FIX Use static call not self call when rebuilding schema #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/5.2/static-not-self
branch
from
d6f1a3e to
8daec3d
Compare
GuySartorelli
commented
Jan 29, 2025
Comment on lines
-5
to
-12
| use GraphQL\Type\Definition\AbstractType; | ||
| use Exception; | ||
| use SilverStripe\Control\Controller; | ||
| use SilverStripe\Dev\SapphireTest; | ||
| use SilverStripe\GraphQL\Schema\Storage\AbstractTypeRegistry; | ||
| use SilverStripe\GraphQL\Controller as GraphQLController; | ||
| use Symfony\Component\Filesystem\Filesystem; | ||
| use ReflectionObject; | ||
| use stdClass; |
There was a problem hiding this comment.
GraphQL\Type\Definition\AbstractType and stdClass were unused, so I've removed them.
| $graphqlController = new GraphQLController('test'); | ||
|
|
||
| // autobuild | ||
| $graphqlController->setAutobuildSchema($autobuild); | ||
|
|
||
| // controller | ||
| if ($controller) { | ||
| // Make it so that Controller::curr() returns a GraphQLController | ||
| $fakeSession = new Session([]); | ||
| $request = Controller::curr()->getRequest(); | ||
| $request->setSession($fakeSession); | ||
| $graphqlController->setRequest($request); | ||
| $graphqlController->pushCurrent(); | ||
| } | ||
| $this->prepGraphQLController($controller, $autobuild); |
There was a problem hiding this comment.
Needed to reuse this code so I've moved it into a new private method
emteknetnz
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue