Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Roave Security advisories to composer #246

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Add Roave Security advisories to composer #246

merged 1 commit into from
Jan 7, 2019

Conversation

Firesphere
Copy link
Contributor

@Firesphere Firesphere commented Jan 1, 2019 •
edited by ScopeyNZ
Loading

Add Security Advisories as dev requirement to

  • Prevent installation of known breached libraries
  • Give devs the option to remove it if they might want to

Related: silverstripe/silverstripe-framework#8548

maxime-rainville
maxime-rainville approved these changes Jan 6, 2019
View reviewed changes
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Behat failure are not related to this.

@ScopeyNZ ScopeyNZ mentioned this pull request Jan 6, 2019
Closed
9 tasks
@maxime-rainville
Copy link
Contributor

@Firesphere Do you mind editing your commit message with a MINOR just for cow's benefit?

@ScopeyNZ
Copy link

ScopeyNZ commented Jan 6, 2019

@Firesphere Do you mind editing your commit message with a MINOR just for cow's benefit?

Preferably NEW rather than MINOR: https://github.com/silverstripe/cow/blob/master/src/Model/Changelog/ChangelogItem.php#L59-L73

@Firesphere
NEW Add Roave Security advisories to composer
a302acf 
Add Security Advisories as dev requirement to
- Prevent installation of known breached libraries
- Give devs the option to remove it if they might want to
@Firesphere
Copy link
Contributor Author

Fixed @ScopeyNZ

@maxime-rainville maxime-rainville merged commit f04beea into silverstripe:4 Jan 7, 2019
@Firesphere Firesphere deleted the patch-1 branch January 7, 2019 21:27
@robbieaverill
Copy link
Contributor

FYI this has been reverted in 810f719 (see silverstripe/silverstripe-framework#8548 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-rainville maxime-rainville maxime-rainville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Firesphere @maxime-rainville @ScopeyNZ @robbieaverill