Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP Bump minimum version of framework #306

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

emteknetnz
Copy link
Member

Issue silverstripe/.github#284

Fixes --prefer-lowest build https://github.com/silverstripe/silverstripe-linkfield/actions/runs/9885486274/job/27303603941

  1. SilverStripe\LinkField\Tests\Tasks\GorriecoeMigrationTaskTest::testGetNeedsMigration with data set "no old table" (false, false)
    SilverStripe\ORM\Connect\DatabaseException: Couldn't run query:

INSERT INTO "GorriecoeMigrationTaskTest_OldLinkTable"
("Title", "Created", "LastEdited", "Type", "URL", "OpenInNewWindow", "MySort")
VALUES
(?, ?, ?, ?, ?, ?, ?)

Table 'ss_tmpdb_1720672189_8044314.GorriecoeMigrationTaskTest_OldLinkTable' doesn't exist

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 5f0795c into silverstripe:4 Jul 16, 2024
14 checks passed
@GuySartorelli GuySartorelli deleted the pulls/4/composer branch July 16, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants