Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Remove TODO comments #515

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion client/src/boot/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ window.document.addEventListener('DOMContentLoaded', () => {
const element = window.document.getElementById('mfa-app');
const schemaURL = element.dataset.schemaurl;

// todo allow Redux to come from react-injector
const store = createStore(
combineReducers(Injector.reducer.getAll()),
window.__REDUX_DEVTOOLS_EXTENSION__ && window.__REDUX_DEVTOOLS_EXTENSION__()
Expand Down
3 changes: 1 addition & 2 deletions client/src/components/Verify.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ class Verify extends Component {
if (defaultMethodDefinition) {
this.setSelectedMethod(defaultMethodDefinition);
} else {
// TODO is this expected? We have the "first" method as the fallback default?
// Use the first method that's not the backup method
this.setSelectedMethod(backupMethod
? registeredMethods.find(method => method.urlSegment !== backupMethod.urlSegment)
Expand Down Expand Up @@ -148,7 +147,7 @@ class Verify extends Component {
onCompleteVerification();
return null;
case 202:
// TODO 202 is returned if multiple MFA methods are required...
// 202 is returned if multiple MFA methods are required...
this.setState({
loading: false,
});
Expand Down
2 changes: 0 additions & 2 deletions docs/en/creating-mfa-method-backend.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# Creating a new MFA method: Backend

<!-- TODO: Documentation covering Method interfaces, etc. -->

## Method availability

If your method isn't available in some situations, and you can determine this via server-side state, you can provide
Expand Down
2 changes: 1 addition & 1 deletion src/RequestHandler/VerificationHandlerTrait.php
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ protected function createStartVerificationResponse(
$registeredMethod = RegisteredMethodManager::singleton()->getFromMember($member, $requestedMethod);
}

// ...Or use the default (TODO: Should we have the default as a fallback? Maybe just if no method is specified?)
// Use the default method if there's no requested method
if (!$registeredMethod) {
$registeredMethod = $member->DefaultRegisteredMethod;
}
Expand Down
6 changes: 3 additions & 3 deletions tests/php/Stub/Null/Method.php
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public function getRegisterHandler(): RegisterHandlerInterface
*/
public function getThumbnail(): string
{
// TODO: Implement getThumbnail() method.
return '';
}

/**
Expand All @@ -69,7 +69,7 @@ public function getThumbnail(): string
*/
public function applyRequirements(): void
{
// TODO: Implement applyRequirements() method.
return;
}

/**
Expand All @@ -89,6 +89,6 @@ public function isAvailable(): bool
*/
public function getUnavailableMessage(): string
{
// TODO: Implement getUnavailableMessage() method.
return '';
}
}
12 changes: 6 additions & 6 deletions tests/php/Stub/Null/RegisterHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class RegisterHandler implements RegisterHandlerInterface, TestOnly
*/
public function start(StoreInterface $store): array
{
// TODO: Implement start() method.
return [];
}

/**
Expand All @@ -32,7 +32,7 @@ public function start(StoreInterface $store): array
*/
public function register(HTTPRequest $request, StoreInterface $store): Result
{
// TODO: Implement register() method.
return new Result();
}

/**
Expand All @@ -44,7 +44,7 @@ public function register(HTTPRequest $request, StoreInterface $store): Result
*/
public function getDescription(): string
{
// TODO: Implement getDescription() method.
return '';
}

/**
Expand All @@ -54,7 +54,7 @@ public function getDescription(): string
*/
public function getSupportLink(): string
{
// TODO: Implement getSupportLink() method.
return '';
}

/**
Expand All @@ -64,7 +64,7 @@ public function getSupportLink(): string
*/
public function getSupportText(): string
{
// TODO: Implement getSupportText() method.
return '';
}

/**
Expand All @@ -74,6 +74,6 @@ public function getSupportText(): string
*/
public function getComponent(): string
{
// TODO: Implement getComponent() method.
return '';
}
}
6 changes: 3 additions & 3 deletions tests/php/Stub/Null/VerifyHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class VerifyHandler implements VerifyHandlerInterface, TestOnly
*/
public function start(StoreInterface $store, RegisteredMethod $method): array
{
// TODO: Implement start() method.
return [];
}

/**
Expand All @@ -35,7 +35,7 @@ public function start(StoreInterface $store, RegisteredMethod $method): array
*/
public function verify(HTTPRequest $request, StoreInterface $store, RegisteredMethod $registeredMethod): Result
{
// TODO: Implement verify() method.
return new Result();
}

/**
Expand All @@ -45,6 +45,6 @@ public function verify(HTTPRequest $request, StoreInterface $store, RegisteredMe
*/
public function getComponent(): string
{
// TODO: Implement getComponent() method.
return '';
}
}