Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to make the summary fields and link function extendable. #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

helenaerni
Copy link

With this change, you can add links to files or rendered data object pages in an extension and add the new links to the "Link" function. And the new options can be added to the summary.

@satrun77
Copy link
Collaborator

satrun77 commented Feb 9, 2023

@helenaerni Thanks for the contribution. I'm unclear about the enhancement in the PR.

The summary fields has extension point in https://github.com/silverstripe/silverstripe-framework/blob/4/src/ORM/DataObject.php#L3945

@helenaerni
Copy link
Author

@satrun77 Thank you for the feedback. The summary fields don't need the extension anymore, thats correct.
The extendable link-function would still be an enhancement because we often have dataobjects renderd to pages as an additional link option.
But I need to update for the asset link first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants