FIX Respect new typehints (#133)

silverstripe · Aug 29, 2024 · f73c5b8 · f73c5b8
1 parent 9ee11bf
commit f73c5b8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/DataFormatter/JSONDataFormatter.php b/src/DataFormatter/JSONDataFormatter.php
@@ -89,7 +89,12 @@ public function convertDataObjectToJSONObject(DataObjectInterface $obj, $fields
                 continue;
             }
 
-            $fieldValue = JSONDataFormatter::cast($obj->obj($fieldName));
+            $dbField = $obj->obj($fieldName);
+            if ($dbField) {
+                $fieldValue = JSONDataFormatter::cast($dbField);
+            } else {
+                $fieldValue = null;
+            }
             $mappedFieldName = $this->getFieldAlias($className, $fieldName);
             $serobj->$mappedFieldName = $fieldValue;
         }
@@ -117,10 +122,11 @@ public function convertDataObjectToJSONObject(DataObjectInterface $obj, $fields
                     ? $this->sanitiseClassName($relClass) . '/' . $obj->$fieldName
                     : $this->sanitiseClassName($className) . "/$id/$relName";
                 $href = Director::absoluteURL($rel);
+                $dbField = $obj->obj($fieldName);
                 $serobj->$relName = ArrayData::array_to_object(array(
                     "className" => $relClass,
                     "href" => "$href.json",
-                    "id" => JSONDataFormatter::cast($obj->obj($fieldName))
+                    "id" => $dbField ? JSONDataFormatter::cast($dbField): ''
                 ));
             }
 

diff --git a/src/DataFormatter/XMLDataFormatter.php b/src/DataFormatter/XMLDataFormatter.php
@@ -125,7 +125,7 @@ public function convertDataObjectWithoutHeader(DataObject $obj, $fields = null,
             if ($fields && !in_array($fieldName, $fields ?? [])) {
                 continue;
             }
-            $fieldValue = $obj->obj($fieldName)->forTemplate();
+            $fieldValue = $obj->obj($fieldName)?->forTemplate();
             if (!mb_check_encoding($fieldValue, 'utf-8')) {
                 $fieldValue = "(data is badly encoded)";
             }