Show in search check for files #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -114,6 +114,17 @@ public function testShouldIndex(): void | |||
| $this->assertFalse($docTwo->shouldIndex()); | |||
| // Document three should NOT be indexable (canView(): false) | |||
| $this->assertFalse($docThree->shouldIndex()); | |||
|
|
|||
| // Document should be NOT indexable (as it's value is changed to ShowInSearch: 0) | |||
There was a problem hiding this comment.
Suggested change
| // Document should be NOT indexable (as it's value is changed to ShowInSearch: 0) | |
| // Document should be NOT indexable (as its value is changed to ShowInSearch: 0) |
blueo
requested changes
Apr 17, 2024
amolswnz
force-pushed
the
feature/show-in-search-check
branch
from
75e2089 to
1f2d6ee
Compare
blueo
requested changes
Apr 21, 2024
blueo
requested changes
Apr 24, 2024
blueo
requested changes
Apr 28, 2024
blueo
approved these changes
Apr 29, 2024
blueo
reviewed
May 1, 2024
| @@ -74,8 +75,7 @@ public function updateCMSFields(FieldList $fields): void | |||
| _t(self::class . '.LastIndexed', 'Last indexed in search') | |||
| ); | |||
|
|
|||
| if ($fields->hasTabSet()) { | |||
| $fields->addFieldToTab('Root.Main', $showInSearchField); | |||
| if ($this->owner instanceof SiteTree) { | |||
There was a problem hiding this comment.
Did you consider doing a check for a field of the same name too? eg if there is already a field don't add it.
There was a problem hiding this comment.
As the field already exists and it's added in getCMSFields to another tab, so finding the field is not an option here. Also if I remove this then for DataObject the Show in Search field is show at top of all it's fields which does not look good in ui perspective, hence this check is added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding "Show in search" and "Last indexed in search" for
DataObjectand for FilesBy default all files are set to "Show in search" as true https://github.com/silverstripe/silverstripe-assets/blob/2/src/File.php#L163
Allow users to easily change the indexing status of a file by checking or unchecking the "Show in search" checkbox.
When checked, the file will be included in the search index.
When unchecked, the file will be excluded from the search index.
Include a field displaying the date and time when the file was last indexed for search.