Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security advisory to dev requirements. #140

Merged

Conversation

maxime-rainville
Copy link
Contributor

@maxime-rainville maxime-rainville commented Nov 16, 2018

Add roave/security-advisories to our composer dev requirements. This will allows us to detect if we are using dependencies with known security issues and make it less likely that we will ship broken code to our beloved users.

Parent issue

Copy link
Contributor

@robbieaverill robbieaverill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but don't merge until the RFC is accepted

@maxime-rainville
Copy link
Contributor Author

RFC has been accepted. Would be cool to approve it now since we got a fair bit of upgrader work planned out.

@robbieaverill robbieaverill merged commit 1c5d826 into silverstripe:master Dec 12, 2018
@maxime-rainville maxime-rainville deleted the pulls/add-security-advasory branch December 12, 2018 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants