-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX Renable email link to submitted file #1236
Merged
sabina-talipova
merged 1 commit into
silverstripe:5.15
from
creative-commoners:pulls/5.15/you-must-log-in
Sep 5, 2023
Merged
FIX Renable email link to submitted file #1236
sabina-talipova
merged 1 commit into
silverstripe:5.15
from
creative-commoners:pulls/5.15/you-must-log-in
Sep 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 4, 2023
emteknetnz
force-pushed
the
pulls/5.15/you-must-log-in
branch
2 times, most recently
from
September 4, 2023 22:32
e0040f4
to
a39aa3b
Compare
sabina-talipova
suggested changes
Sep 5, 2023
emteknetnz
force-pushed
the
pulls/5.15/you-must-log-in
branch
from
September 5, 2023 04:45
a39aa3b
to
9ef8f7e
Compare
sabina-talipova
suggested changes
Sep 5, 2023
emteknetnz
force-pushed
the
pulls/5.15/you-must-log-in
branch
2 times, most recently
from
September 5, 2023 22:04
e536b2d
to
423c01f
Compare
sabina-talipova
suggested changes
Sep 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Works perfect.
Just small change.
emteknetnz
force-pushed
the
pulls/5.15/you-must-log-in
branch
from
September 5, 2023 22:54
423c01f
to
f1510dc
Compare
sabina-talipova
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Solution was tested locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1225
Replaces #1228