FIX Pass AuthenticatorSelectionCriteria as argument to PublicKeyCrede…

…ntialCreationOptions constructor
silverstripe · Sep 21, 2023 · 7a95f20 · 7a95f20
1 parent 251bef6
commit 7a95f20
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/RegisterHandler.php b/src/RegisterHandler.php
@@ -259,7 +259,7 @@ protected function getCredentialCreationOptions(
             $this->getUserEntity($store->getMember()),
             random_bytes(32),
             [new PublicKeyCredentialParameters('public-key', Algorithms::COSE_ALGORITHM_ES256)],
-            40000
+            $this->getAuthenticatorSelectionCriteria()
         );
         $credentialOptions->setAuthenticatorSelection($this->getAuthenticatorSelectionCriteria());
         $credentialOptions->setAttestation(PublicKeyCredentialCreationOptions::ATTESTATION_CONVEYANCE_PREFERENCE_NONE);
@@ -282,7 +282,6 @@ protected function getCredentialCreationOptions(
      */
     protected function getAuthenticatorSelectionCriteria(): AuthenticatorSelectionCriteria
     {
-        return AuthenticatorSelectionCriteria::create()
-            ->setAuthenticatorAttachment((string) $this->config()->get('authenticator_attachment'));
+        return AuthenticatorSelectionCriteria::create((string) $this->config()->get('authenticator_attachment'));
     }
 }