Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mongoid 8.x.x support #71

Closed
wants to merge 6 commits into from
Closed

Mongoid 8.x.x support #71

wants to merge 6 commits into from

Conversation

randikabanura
Copy link

@randikabanura randikabanura commented Jan 9, 2023

Mongoid has released the mongoid 8 version. hence this PR adds support for mongoid 8.0.x versions for the gem.

No breaking changes related to deletion in mongoid 8 changelog

Tests are passing without an issue.
image
Note: Two tests were updated due to Rspec warnings.

@randikabanura randikabanura marked this pull request as ready for review January 10, 2023 02:24
@kaspermeyer
Copy link

@randikabanura would you be willing to check if your PR works with the latest Mongoid 8.1.1 as well? It doesn't look like the maintainer has taken a look at this yet, so we might as well bring it up to date. I can give it a shot as well, if you don't have the time.

@randikabanura
Copy link
Author

@kaspermeyer I will check if the PR works for the latest Mongoid 8.1.1 within this week and update accordingly. If you are able to do it earlier that be great as well.

@randikabanura randikabanura changed the title Mongoid 8.0.x support Mongoid 8.x.x support Sep 7, 2023
@randikabanura
Copy link
Author

Mongoid has released the mongoid 8 version. I have updated the PR to support mongoid 8.x.x versions for the gem.

No breaking changes related to deletion in mongoid 8.1 changelog

Tests are passing without an issue.

@randikabanura
Copy link
Author

randikabanura commented Sep 8, 2023

@simi Please check the changes and approve. Also after that we can release a new version.

@simi
Copy link
Owner

simi commented Sep 9, 2023

It seems CI needs to be fixed, I'll take a look.

@johnnyshields
Copy link
Collaborator

Closing in favor of #72

@johnnyshields
Copy link
Collaborator

The fix is released on 0.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants