Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/authentication #183

Open
wants to merge 86 commits into
base: master
Choose a base branch
from
Open

Feature/authentication #183

wants to merge 86 commits into from

Conversation

daniebrill
Copy link

What type of PR is this?
Backend Feature
UI Feature

What this PR does / why we need it:
Add authentication feature
Which issue(s) this PR fixes (if exists):

Does this PR introduce a breaking change, if so what is it?:

Introduce cookies to protect API endpoints

Additional documentation:

Jackafive753 and others added 30 commits May 28, 2021 14:10
@Jackafive753
#SOS-15
8daf59a 
/collector/structs.go
+ AccountSpecifiedFiels struct to save AccountId and AccountName

/collector/aws/common/structs.go
+ add Method getAccountName()

/collector/aws/detector.go
+ save in DetectorManager the accountName from config file

/collector/resources/*
+ save AccountSpecifiedFields with values in detectedStructs
@Jackafive753
#SOS-22
35a3f71 
* elasticsearch.go getDynamicMatchQuery
   add: if filterName is Data.AccountID then build boolQuery for given AccountIDs
@Jackafive753
#SOS-15
5866b6e 
fit MockAWSManager to the modified AWSManager
@daniebrill
#SOS-23 Add getAccounts + save account information in event_status
839ae2f
@daniebrill
#SOS-23 Use querylimit in aggregation + add error handling for type a…
6cd0a85 
…ssertion
@daniebrill
#SOS-23 Fix existing tests + code format
f8e931b
@daniebrill
#SOS-23 Modify GetAccounts for specific execution ID
259ccf7
@daniebrill
#SOS-23 Fit MockStorage to modified interface StorageDescriber
45db9b4
@daniebrill
#SOS-23 Add tests in interpolation_test.go and server_test.go
2f3c15c
@Jackafive753
#SOS-20
1fd641a 
* save arn in resourceID field
+ add values in test objects
@daniebrill
#SOS-23 Add test for elasticsearch GetAccounts
9c157f2
@Jackafive753
#SOS-16
0f68ad2 
+ add accounts to the provider store
+ Show Accounts in a chip-list like resources
+ add Accounts to filter
@Jackafive753
Merge remote-tracking branch 'origin/feature_multi_account_selection'…
2b48f30 
… into feature_multi_account_selection
@daniebrill
#SOS18 Add multiaccount selection functionality to tables
bf4c57d
@Jackafive753
#SOS-16
ecbe7ef 
add comments
@Jackafive753
Merge remote-tracking branch 'origin/feature_multi_account_selection'…
5a7065e 
… into feature_multi_account_selection
@Jackafive753
#SOS-18
5ea12e5 
add spentAccounts in summary
add things to success tests
@daniebrill
#SOS-18
2f99548 
Add multiaccount-selection functionality for RessourceCharts
@Jackafive753
Merge pull request #1 from evoila/feature_multi_account_selection
2c3e562 
Feature multi account selection
@florianbieser
#SOS-31
8416b89
@daniebrill
#SOS-26
e55138e 
Add EKS to collector configuration file
@Jackafive753
#SOS-25
454eb3a 
add EKS Cluster Check with test-file
@Jackafive753
#SOS-25
1165abe 
change PricingFilter
@Jackafive753
#SOS-25
2effc76 
change PricingFilter
@Jackafive753
#SOS-25
99ad636 
change PricingFilter
@Jackafive753
#SOS-25
12893e8 
change PricingFilter
Changed some things to test -> Delete if somehting breaks
5b7187c
@Jackafive753
Fix ESLint Errors
b95df02
I dont care
9429c6f
Merge remote-tracking branch 'origin/Testing_CSV' into Testing_CSV
49ec1ad 
# Conflicts:
#	ui/src/components/Dashboard/CSVDownloadButton.js
daniebrill and others added 28 commits July 9, 2021 23:03
@daniebrill
Add account section for authentication to api.yaml + extend api confi…
f8677e8 
…g struct
Did more things
1161a8b
@Jackafive753
# SOS-30
18d6bb9 
in ecs get tasks if launchtype == Fargate
Cleanup and more
e88c686
Removed some comments
1c2ef4b
@Jackafive753
# SOS-48
d9b9549 
add login api endpoint
add login function in server
@Jackafive753
# SOS-48
3919a61 
add test func
Error output corrected with correct status code
@Jackafive753
token expire time from 5 minute to 1 hour
0f438d4
@Jackafive753
Merge branch 'master' into feature_add_EKS
8652ce0
@Jackafive753
Merge pull request #4 from evoila/feature_add_EKS
c0b22ea 
Feature add eks
@Jackafive753
Merge pull request #5 from evoila/feature_add_ECS
c8f8594 
Feature add ecs
@Jackafive753
Merge pull request #6 from evoila/feature_all_summary_report
c37b051 
Feature all summary report
@Jackafive753
Merge branch 'Presentation' into master
747ebba
@Jackafive753
Merge pull request similarweb#7 from evoila/master
b398f03 
Master for presentation issue
@Jackafive753
Merge branch 'Presentation' into feature/authentication
e7be2b2
@Jackafive753
add authentication with cookie
7c31628 
change tests or authentication with cookie
@Jackafive753
add authentication throttle
7071ebd
@daniebrill
Add authentication request + initial call in DataFactory.js
c01bbd0
@Jackafive753
# SOS-57
ab6405e 
remove account charts with not data found
Experimental first version of login.js
13c945a
@daniebrill
Adjust api for cookie requests
3864503
@Jackafive753
change token library
0321b8d 
delete unnecessary console
define SameSite
@daniebrill
Add UI Authentication functionality
aace352
@daniebrill
Replace unmaintained auth library in api server test files
81fe9fc
@Jackafive753
set account to filters if an account specific Chart is clicked
f8adc70
@daniebrill
Show error message for wrong credentials + login with enter
16da0d8
@Jackafive753
authentication needed for report
a3fdc4f 
samesite from a cookie is laxmode
@Jackafive753
position test method
21302ae
kaplanelad
kaplanelad reviewed Aug 1, 2021
View reviewed changes
Copy link
Contributor

@kaplanelad kaplanelad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @daniebrill,

This branch includes also the previews changes that have already been reviewed. for a better review, can you please merge the branch with feature/multi_account_selection ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaplanelad kaplanelad kaplanelad left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@daniebrill @kaplanelad @Jackafive753 @florianbieser @DerOtt