Address CI issues in DatabaseTracker #3423
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suojae
force-pushed
the
feature/add-dispose-method
branch
3 times, most recently
from
21ba02a to
eb224c4
Compare
|
Looks like you also need to run |
suojae
force-pushed
the
feature/add-dispose-method
branch
from
eb224c4 to
62df868
Compare
|
Thanks! I’ve addressed the formatting issue as suggested. Please let me know if there’s anything else I can help with or any additional changes you'd like me to make. |
|
Thanks, and sorry for being slow to respond. We still need to investigate the crash in the test (see the failing github action). It looks like we might close the database twice somehow, or fail to unregister a native callback. That shouldn't be possible (and might be a bug in |
|
Thanks! I’ll take a look at sqlite3 and see if I can spot anything related to the crash. I'll let you know if I find anything useful :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the CI issues reported in the previous PR.
The CI failures appear to be environment-specific.
Related Issue