Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTS5 highlight/snippet nullable #3427

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

FaFre
Copy link
Contributor

@FaFre FaFre commented Jan 20, 2025

In case the indexed value is null (e.g. multiple columns in the FTS5 table) highlight and snippet also return null.

@simolus3
Copy link
Owner

Thanks! It looks like the tests need to be updated as well. Also, we currently assume all fts5 columns are non-nullable (nullable: true should be set when creating table columns in _Fts5Module.parseTable but isn't). So we should probably fix that too.

I'm thinking about a way to make this non-breaking... Perhaps we should only consider the columns to be nullable when the user has opted into a certain sqlite versions in the build options. But I can take care of that part.

@simolus3 simolus3 merged commit bb7bcb0 into simolus3:develop Jan 21, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants