Add support for single detector maps #690
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tskisner
approved these changes
Mar 10, 2024
| job_ops.mapmaker.apply(obs_data) | ||
| # See if user wants separate detector maps | ||
| if hasattr(otherargs, "detmaps") and otherargs.detmaps: | ||
| my_dets = data.all_local_detectors() |
There was a problem hiding this comment.
This might cause problems if some detectors are cut in all observations. You could replace this line with
my_dets = data.all_local_detectors(flagmask=defaults.det_mask_invalid)
to get the global detectors which are not cut by major issues.
| if data.comm.comm_world is None: | ||
| all_dets = my_dets | ||
| else: | ||
| from matplotlib.cbook import flatten |
There was a problem hiding this comment.
Interesting, I had never seen this method! Definitely useful for the typical use case of calling gather / allgather on python lists, resulting in a list of lists. We could consider doing a namespace import as toast.mpi.flatten and use it more generally.
|
This PR requires hpc4cmb/toast#743 to be merged first. |
keskitalo
force-pushed
the
detector_maps
branch
from
89ddb21 to
79a1bc6
Compare
Merged
|
This PR is superseded by #877 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.