fix: Allow partial match for manual sync

See GoogleContainerTools#9326

pkg/skaffold/sync/sync.go

@@ -227,7 +227,6 @@ func latestTag(image string, builds []graph.Artifact) string {
 
 func intersect(ctx context.Context, contextWd, containerWd string, syncRules []*latest.SyncRule, files []string) (syncMap, error) {
 	ret := make(syncMap)
-	hadMismatch := false
 	for _, f := range files {
 		relPath, err := filepath.Rel(contextWd, f)
 		if err != nil {
@@ -240,16 +239,12 @@ func intersect(ctx context.Context, contextWd, containerWd string, syncRules []*
 		}
 
 		if len(dsts) == 0 {
-			log.Entry(ctx).Infof("Changed file %s does not match any sync pattern. Skipping sync", relPath)
-			hadMismatch = true
+			log.Entry(ctx).Infof("Changed file %s does not match any sync pattern. Skipping sync for it", relPath)
 			continue
 		}
 
 		ret[f] = dsts
 	}
-	if len(ret) == 0 && hadMismatch {
-		return nil, nil
-	}
 	return ret, nil
 }
 

pkg/skaffold/sync/sync_test.go

@@ -269,6 +269,13 @@ func TestNewSyncItem(t *testing.T) {
 					Tag: "placeholder",
 				},
 			},
+			expected: &Item{
+				Image: "placeholder",
+				Copy:  map[string][]string{},
+				Delete: map[string][]string{
+					"index.html": {"index.html"},
+				},
+			},
 		},
 		{
 			description: "manual: not delete syncable",
@@ -289,6 +296,13 @@ func TestNewSyncItem(t *testing.T) {
 					Tag: "placeholder",
 				},
 			},
+			expected: &Item{
+				Image: "placeholder",
+				Copy: map[string][]string{
+					"index.html": {"/static/index.html"},
+				},
+				Delete: map[string][]string{},
+			},
 		},
 		{
 			description: "manual: err bad pattern",
@@ -767,7 +781,11 @@ func TestNewSyncItem(t *testing.T) {
 					}]
 				}`,
 			},
-			expected: nil,
+			expected: &Item{
+				Image:  "test:123",
+				Copy:   map[string][]string{},
+				Delete: map[string][]string{},
+			},
 		},
 
 		// Auto with Jib