Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 203a #284

Closed
wants to merge 3 commits into from
Closed

Fix issue 203a #284

wants to merge 3 commits into from

Conversation

kujaku11
Copy link
Collaborator

@kujaku11 kujaku11 commented Sep 1, 2023

Updating how metadata is translated from MTH5 to TF.

  • updated to use only a single metadata object survey_metadata pulled from a run_ts object.
    • Added logic to get the survey ID from KernelDataset.df
    • Removed older logic to get station metadata from MTH5
  • Updated tests/synthetic/test_processing.py to output a z-file directly from TF object
  • TODO: Pack decimation level, number of samples, and band indicies into TF for a more accurate and complete representation of the transfer function estimates, and output to a z-file.

kkappler and others added 3 commits August 30, 2023 12:45
Modify KernelDataset so that it keeps a copy of survey metadata
This survey metadata is still not being filed correctly in the
TF object however.
@kujaku11
Copy link
Collaborator Author

kujaku11 commented Sep 1, 2023

@kkappler I update mt_metadata which fixed some of the failed tests. The ones failing now are:

  • docs test
  • RMS tests

I didn't pull from FC's. So maybe once you've cleaned up your FC branch, that can be pulled into this branch and then complete the pull requests if tests pass.

@kkappler
Copy link
Collaborator

kkappler commented Sep 4, 2023

@kujaku11 I manually merged your tests into fourier_coefficients on fix_issue_203a_manual_merge and tests pass (except docs) on 3.8.
I am abandoning this branch and will merge fix_issue_203a_manual_merge into fourier_coefficients

@kkappler kkappler closed this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants