This repository has been archived by the owner on Feb 22, 2019. It is now read-only.
Adding full support for longs/negative long values #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I copied most of the parts of the methods which seemed still applicable instead of re-writing them entirely. I think its okay since most of it was generated by the script in the first place.
This thread gives you a decent idea of what javascript can support in terms of precision:
http://stackoverflow.com/a/307200/883795
Seemed to work for random ranges of positive and negative longs that I tested with. You might want to change the parser back to BinaryParser.toLong, but that is up to you. I think it does not exactly work with the new format, but I'm not sure.
Can you pull the counter column pull request in Helenus with this change?
Thanks!