Skip to content
This repository has been archived by the owner on Feb 22, 2019. It is now read-only.

Adding full support for longs/negative long values #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

calvinfo
Copy link

I copied most of the parts of the methods which seemed still applicable instead of re-writing them entirely. I think its okay since most of it was generated by the script in the first place.

This thread gives you a decent idea of what javascript can support in terms of precision:
http://stackoverflow.com/a/307200/883795

Seemed to work for random ranges of positive and negative longs that I tested with. You might want to change the parser back to BinaryParser.toLong, but that is up to you. I think it does not exactly work with the new format, but I'm not sure.

Can you pull the counter column pull request in Helenus with this change?

Thanks!

@calvinfo
Copy link
Author

The issue is also referenced here:
https://issues.apache.org/jira/browse/THRIFT-1497

There's a problem representing anything larger than 2^53 in Javascript, but it looks like there's a request for it to be patched upstream using this library: https://github.com/broofa/node-int64.

Any thoughts? I'd like to see counters in helenus, though none of my counters involve anything needing 53 bits of precision.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant