Fix coding style #357
tvdijenphp.yml
on: push
Annotations
10 errors and 14 warnings
|
TooManyArguments:
src/Controller/Adfs.php#L45
src/Controller/Adfs.php:45:27: TooManyArguments: Too many arguments for SimpleSAML\Metadata\MetaDataStorageHandler::getMetadataHandler - expecting 0 but saw 1 (see https://psalm.dev/026)
|
|
ArgumentTypeCoercion:
src/Controller/Adfs.php#L73
src/Controller/Adfs.php:73:59: ArgumentTypeCoercion: Argument 1 of SimpleSAML\Metadata\MetaDataStorageHandler::getMetaDataConfig expects string, but parent type null|scalar provided (see https://psalm.dev/193)
|
|
PossiblyNullArgument:
src/Controller/Adfs.php#L73
src/Controller/Adfs.php:73:59: PossiblyNullArgument: Argument 1 of SimpleSAML\Metadata\MetaDataStorageHandler::getMetaDataConfig cannot be null, possibly null value provided (see https://psalm.dev/078)
|
|
ArgumentTypeCoercion:
src/Controller/Adfs.php#L135
src/Controller/Adfs.php:135:48: ArgumentTypeCoercion: Argument 1 of SimpleSAML\IdP::handleLogoutResponse expects string, but parent type null|scalar provided (see https://psalm.dev/193)
|
|
PossiblyNullArgument:
src/Controller/Adfs.php#L135
src/Controller/Adfs.php:135:48: PossiblyNullArgument: Argument 1 of SimpleSAML\IdP::handleLogoutResponse cannot be null, possibly null value provided (see https://psalm.dev/078)
|
|
ArgumentTypeCoercion:
src/Controller/Adfs.php#L135
src/Controller/Adfs.php:135:58: ArgumentTypeCoercion: Argument 2 of SimpleSAML\IdP::handleLogoutResponse expects null|string, but parent type null|scalar provided (see https://psalm.dev/193)
|
|
UndefinedDocblockClass:
src/Controller/Adfs.php#L160
src/Controller/Adfs.php:160:21: UndefinedDocblockClass: Docblock-defined class, interface or enum named SimpleSAML\WSSecurity\XML\wsdl\Definitions does not exist (see https://psalm.dev/200)
|
|
TooManyArguments:
src/IdP/ADFS.php#L61
src/IdP/ADFS.php:61:21: TooManyArguments: Too many arguments for SimpleSAML\Metadata\MetaDataStorageHandler::getMetadataHandler - expecting 0 but saw 1 (see https://psalm.dev/026)
|
|
PossiblyNullArgument:
src/IdP/ADFS.php#L197
src/IdP/ADFS.php:197:43: PossiblyNullArgument: Argument 2 of SimpleSAML\XMLSecurity\Key\PrivateKey::fromFile cannot be null, possibly null value provided (see https://psalm.dev/078)
|
|
TooManyArguments:
src/IdP/ADFS.php#L252
src/IdP/ADFS.php:252:24: TooManyArguments: Too many arguments for SimpleSAML\Metadata\MetaDataStorageHandler::getMetadataHandler - expecting 0 but saw 1 (see https://psalm.dev/026)
|
|
MixedAssignment:
src/Controller/Adfs.php#L160
src/Controller/Adfs.php:160:9: MixedAssignment: Unable to determine the type that $document is being assigned to (see https://psalm.dev/032)
|
|
MixedPropertyFetch:
src/Controller/Adfs.php#L162
src/Controller/Adfs.php:162:9: MixedPropertyFetch: Cannot fetch property on mixed var $document (see https://psalm.dev/034)
|
|
MixedPropertyAssignment:
src/Controller/Adfs.php#L162
src/Controller/Adfs.php:162:9: MixedPropertyAssignment: $document->ownerDocument of type mixed cannot be assigned to (see https://psalm.dev/033)
|
|
MixedPropertyAssignment:
src/Controller/Adfs.php#L163
src/Controller/Adfs.php:163:9: MixedPropertyAssignment: $document->ownerDocument of type mixed cannot be assigned to (see https://psalm.dev/033)
|
|
MixedAssignment:
src/Controller/Adfs.php#L165
src/Controller/Adfs.php:165:9: MixedAssignment: Unable to determine the type that $metaxml is being assigned to (see https://psalm.dev/032)
|
|
MixedMethodCall:
src/Controller/Adfs.php#L165
src/Controller/Adfs.php:165:46: MixedMethodCall: Cannot determine the type of $document->ownerDocument when calling method saveXML (see https://psalm.dev/015)
|
|
MixedArgument:
src/Controller/Adfs.php#L168
src/Controller/Adfs.php:168:43: MixedArgument: Argument 2 of hash cannot be mixed, expecting string (see https://psalm.dev/030)
|
|
MixedArgument:
src/Controller/Adfs.php#L174
src/Controller/Adfs.php:174:31: MixedArgument: Argument 1 of Symfony\Component\HttpFoundation\Response::setContent cannot be mixed, expecting null|string (see https://psalm.dev/030)
|
|
MixedArgument:
src/IdP/ADFS.php#L56
src/IdP/ADFS.php:56:19: MixedArgument: Argument 1 of parse_str cannot be mixed, expecting string (see https://psalm.dev/030)
|
|
MixedAssignment:
src/IdP/ADFS.php#L58
src/IdP/ADFS.php:58:9: MixedAssignment: Unable to determine the type that $requestid is being assigned to (see https://psalm.dev/032)
|
|
PossiblyUndefinedGlobalVariable:
tests/metadata/adfs-idp-hosted.php#L6
tests/metadata/adfs-idp-hosted.php:6:1: PossiblyUndefinedGlobalVariable: Possibly undefined global variable $metadata, first seen on line 6 (see https://psalm.dev/126)
|
|
PossiblyUndefinedGlobalVariable:
tests/metadata/adfs-sp-remote.php#L3
tests/metadata/adfs-sp-remote.php:3:1: PossiblyUndefinedGlobalVariable: Possibly undefined global variable $metadata, first seen on line 3 (see https://psalm.dev/126)
|
|
PropertyNotSetInConstructor:
tests/src/Controller/AdfsControllerTest.php#L23
tests/src/Controller/AdfsControllerTest.php:23:29: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\adfs\Controller\AdfsControllerTest::$config is not defined in constructor of SimpleSAML\Test\Module\adfs\Controller\AdfsControllerTest or in any methods called in the constructor (see https://psalm.dev/074)
|
|
PropertyNotSetInConstructor:
tests/src/Controller/AdfsControllerTest.php#L26
tests/src/Controller/AdfsControllerTest.php:26:23: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\adfs\Controller\AdfsControllerTest::$session is not defined in constructor of SimpleSAML\Test\Module\adfs\Controller\AdfsControllerTest or in any methods called in the constructor (see https://psalm.dev/074)
|