Fix signed assertion #361

Annotations

10 errors and 14 warnings

src/Controller/Adfs.php:44:27: TooManyArguments: Too many arguments for SimpleSAML\Metadata\MetaDataStorageHandler::getMetadataHandler - expecting 0 but saw 1 (see https://psalm.dev/026)

src/Controller/Adfs.php#L72

src/Controller/Adfs.php:72:59: ArgumentTypeCoercion: Argument 1 of SimpleSAML\Metadata\MetaDataStorageHandler::getMetaDataConfig expects string, but parent type null|scalar provided (see https://psalm.dev/193)

src/Controller/Adfs.php#L72

src/Controller/Adfs.php:72:59: PossiblyNullArgument: Argument 1 of SimpleSAML\Metadata\MetaDataStorageHandler::getMetaDataConfig cannot be null, possibly null value provided (see https://psalm.dev/078)

src/Controller/Adfs.php#L134

src/Controller/Adfs.php:134:48: ArgumentTypeCoercion: Argument 1 of SimpleSAML\IdP::handleLogoutResponse expects string, but parent type null|scalar provided (see https://psalm.dev/193)

src/Controller/Adfs.php#L134

src/Controller/Adfs.php:134:48: PossiblyNullArgument: Argument 1 of SimpleSAML\IdP::handleLogoutResponse cannot be null, possibly null value provided (see https://psalm.dev/078)

src/Controller/Adfs.php#L134

src/Controller/Adfs.php:134:58: ArgumentTypeCoercion: Argument 2 of SimpleSAML\IdP::handleLogoutResponse expects null|string, but parent type null|scalar provided (see https://psalm.dev/193)

src/IdP/ADFS.php#L61

src/IdP/ADFS.php:61:21: TooManyArguments: Too many arguments for SimpleSAML\Metadata\MetaDataStorageHandler::getMetadataHandler - expecting 0 but saw 1 (see https://psalm.dev/026)

src/IdP/ADFS.php#L197

src/IdP/ADFS.php:197:43: PossiblyNullArgument: Argument 2 of SimpleSAML\XMLSecurity\Key\PrivateKey::fromFile cannot be null, possibly null value provided (see https://psalm.dev/078)

src/IdP/ADFS.php#L252

src/IdP/ADFS.php:252:24: TooManyArguments: Too many arguments for SimpleSAML\Metadata\MetaDataStorageHandler::getMetadataHandler - expecting 0 but saw 1 (see https://psalm.dev/026)

src/IdP/ADFS.php#L300

src/IdP/ADFS.php:300:83: UndefinedConstant: Constant SimpleSAML\SAML11\Constants::NAMEID_TRANSIENT is not defined (see https://psalm.dev/020)

src/IdP/ADFS.php#L56

src/IdP/ADFS.php:56:19: MixedArgument: Argument 1 of parse_str cannot be mixed, expecting string (see https://psalm.dev/030)

src/IdP/ADFS.php#L58

src/IdP/ADFS.php:58:9: MixedAssignment: Unable to determine the type that $requestid is being assigned to (see https://psalm.dev/032)

src/IdP/ADFS.php#L59

src/IdP/ADFS.php:59:9: MixedAssignment: Unable to determine the type that $issuer is being assigned to (see https://psalm.dev/032)

src/IdP/ADFS.php#L62

src/IdP/ADFS.php:62:52: MixedArgument: Argument 1 of SimpleSAML\Metadata\MetaDataStorageHandler::getMetaDataConfig cannot be mixed, expecting string (see https://psalm.dev/030)

src/IdP/ADFS.php#L64

src/IdP/ADFS.php:64:95: MixedOperand: Right operand cannot be mixed (see https://psalm.dev/059)

src/IdP/ADFS.php#L86

src/IdP/ADFS.php:86:65: MixedArgument: Argument 1 of SimpleSAML\Utils\HTTP::checkURLAllowed cannot be non-empty-mixed, expecting string (see https://psalm.dev/030)

src/IdP/ADFS.php#L153

src/IdP/ADFS.php:153:17: MixedArgumentTypeCoercion: Argument 1 of SimpleSAML\Utils\Attributes::getAttributeNamespace expects string, but parent type array-key provided (see https://psalm.dev/194)

src/IdP/ADFS.php#L157

src/IdP/ADFS.php:157:43: MixedArgument: Argument 1 of htmlspecialchars cannot be mixed, expecting string (see https://psalm.dev/030)

src/IdP/ADFS.php#L158

src/IdP/ADFS.php:158:38: MixedArgument: Argument 1 of htmlspecialchars cannot be mixed, expecting string (see https://psalm.dev/030)

src/IdP/ADFS.php#L160

src/IdP/ADFS.php:160:33: MixedAssignment: Unable to determine the type that $value is being assigned to (see https://psalm.dev/032)

tests/metadata/adfs-idp-hosted.php#L6

tests/metadata/adfs-idp-hosted.php:6:1: PossiblyUndefinedGlobalVariable: Possibly undefined global variable $metadata, first seen on line 6 (see https://psalm.dev/126)

tests/metadata/adfs-sp-remote.php#L3

tests/metadata/adfs-sp-remote.php:3:1: PossiblyUndefinedGlobalVariable: Possibly undefined global variable $metadata, first seen on line 3 (see https://psalm.dev/126)

tests/src/Controller/AdfsControllerTest.php#L23

tests/src/Controller/AdfsControllerTest.php:23:29: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\adfs\Controller\AdfsControllerTest::$config is not defined in constructor of SimpleSAML\Test\Module\adfs\Controller\AdfsControllerTest or in any methods called in the constructor (see https://psalm.dev/074)

tests/src/Controller/AdfsControllerTest.php#L26

tests/src/Controller/AdfsControllerTest.php:26:23: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\adfs\Controller\AdfsControllerTest::$session is not defined in constructor of SimpleSAML\Test\Module\adfs\Controller\AdfsControllerTest or in any methods called in the constructor (see https://psalm.dev/074)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix signed assertion #361

Quality control

Fix signed assertion #361

Jobs

Run details

Annotations

This job succeeded

Re-running jobs...