Use saml 1.1 and ws-security libraries to build metadata and messages #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tvdijen
commented
Sep 1, 2024
•
tvdijen
commented
- Relies on Prefix filenames with file:// if necessary, or openssl will fail xml-security#54 to be merged.
- Relies on Disconnect ADFS-module from SimpleSAMLphp simplesamlphp#2227 to be merged (reason for failing tests)
* A hook to generate metadata * Fix coding style & strict comparison --------- Co-authored-by: Tim van Dijen <[email protected]>
* A hook to generate metadata * Fix coding style & strict comparison --------- Co-authored-by: Tim van Dijen <[email protected]>
* Do not rely on SimpleSAMLphp for metadata-building * Fix * Introduce a clokc * Generate ID * Cleanup
tvdijen
force-pushed
the
feature/library
branch
from
b71496c to
c7e80ba
Compare
tvdijen
force-pushed
the
feature/library
branch
from
6246949 to
bb735c1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22 +/- ##
===========================================
- Coverage 3.92% 3.25% -0.67%
- Complexity 73 103 +30
===========================================
Files 5 3 -2
Lines 408 492 +84
===========================================
Hits 16 16
- Misses 392 476 +84 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.