Implement IntegerElementTrait

simplesamlphp · Nov 29, 2024 · 424911f · 424911f
1 parent 364bff4
commit 424911f
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/src/XML/ds/X509SerialNumber.php b/src/XML/ds/X509SerialNumber.php
@@ -21,9 +21,9 @@ final class X509SerialNumber extends AbstractDsElement
 
 
     /**
-     * @param int $content
+     * @param string $content
      */
-    public function __construct(int $content)
+    public function __construct(string $content)
     {
         $this->setContent($content);
     }

diff --git a/tests/XML/ds/X509DataTest.php b/tests/XML/ds/X509DataTest.php
@@ -111,7 +111,7 @@ public function testMarshalling(): void
                         'C=US,ST=Hawaii,L=Honolulu,O=SimpleSAMLphp HQ,CN=SimpleSAMLphp Testing CA,emailAddress=%s',
                         '[email protected]',
                     )),
-                    new X509SerialNumber(2),
+                    new X509SerialNumber('2'),
                 ),
                 new X509SubjectName(self::$certData['name']),
                 new X509Digest(self::$digest, C::DIGEST_SHA256),

diff --git a/tests/XML/ds/X509IssuerSerialTest.php b/tests/XML/ds/X509IssuerSerialTest.php
@@ -57,7 +57,7 @@ public function setUp(): void
         /** @var string[] $details */
         $details = self::$key->getCertificateDetails();
         self::$issuer = new X509IssuerName(CertificateUtils::parseIssuer($details['issuer']));
-        self::$serial = new X509SerialNumber(intval($details['serialNumber']));
+        self::$serial = new X509SerialNumber($details['serialNumber']);
     }
 
 

diff --git a/tests/XML/ds/X509SerialNumberTest.php b/tests/XML/ds/X509SerialNumberTest.php
@@ -43,7 +43,7 @@ public static function setUpBeforeClass(): void
      */
     public function testMarshalling(): void
     {
-        $serialNumber = new X509SerialNumber(123456);
+        $serialNumber = new X509SerialNumber('123456');
 
         $this->assertEquals(
             self::$xmlRepresentation->saveXML(self::$xmlRepresentation->documentElement),