This repository has been archived by the owner on Mar 11, 2024. It is now read-only.
first pr #6
Open
first pr #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is this gonna get merged or xd? |
|
@yurtemre7 Yes sorry I'll fixup tv first then look at iOS |
rafifos
suggested changes
Feb 8, 2021
| @@ -20,6 +20,9 @@ | |||
| # is commented out by default. | |||
| #.vscode/ | |||
|
|
|||
| # iOS | |||
| ios | |||
There was a problem hiding this comment.
Sorry I have OCD.
Suggested change
| ios | |
| ios/ |
| (currentAmount?.toString() ?? "?") + | ||
| " / " + | ||
| (totalAmount?.toString() ?? "?"), | ||
| (currentAmount?.toString() ?? "?") + " / " + (totalAmount?.toString() ?? "?"), |
There was a problem hiding this comment.
I have approximately 0 confidence with Dart but it supports interpolation?
There was a problem hiding this comment.
yes dart supports string interpolation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried scanning your code and try to understand that and while I looked at specific points I've found some corrections or way to to improve it.
The only critical thing changed here is the description of an anime, because some times there where some "special chars" like "hyphens (-)" that were not displayed correctly.
The other changes occurred while auto-formatting the code by my IDE, (we better have the same format style though the next time)