Allow custom association name for subscriptions #162
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #161, if available:
Summary
Right now I just added a failing spec for custom association name. I assumed we can use the same config for custom subscriptions table, but of course I'll let you decide this @simukappu
There are many methods inside the subscriber.rb that depends on the default
subscriptions
association name. As said, if anyone attaches this concern to a model that has subscriptions associations, it breaks functionalityPlease give me instructions on the direction you prefer to move forward about this
Thanks