Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/full screen #587

Closed
wants to merge 37 commits into from
Closed

Feature/full screen #587

wants to merge 37 commits into from

Conversation

interim17
Copy link
Contributor

@interim17 interim17 commented Oct 15, 2024 •
edited
Loading

Time estimate or Size

small

Problem

Follow up to recent embed controls #556
Closes #586, advances #548

Solution

Add a button and check a piece of global state to manage full screen ability in embedded windows.

with @meganrm

  • New feature (non-breaking change which adds functionality)

interim17 and others added 30 commits July 30, 2024 12:45
@interim17
add vertical flexbox, copy to clipboard and get url param value utils
43ff6ad
@interim17
comment out unused radio button styling from ant-var.less
a3eca32
@interim17
update shareTrajectoryModal to include embed snippet and new styling
003a8f5
@interim17
rename radio group state value
62ae60b
@interim17
streamline number inputs
9f5a2a9
@interim17
remove fragment comment
deb53f5
@interim17
add tests for utils
5931513
@interim17
max embedded size is 4k resolution
f21aa06
@interim17
add embed full screen to redux
7b99c08
@interim17
minimal controls and full screen button for small embeds
41545e2
@interim17
Merge branch 'main' of https://github.com/simularium/simularium-website…
9cfe61a 
… into feature/embed-controls
@interim17
remove dev preview tool
b7bc398
@interim17
remove unused imports
ef44205
@interim17
use embeddedDisplayCutoffs to control rendering in ViewerPanel
1d2d4fd
@interim17
remove outdated styles/utils file
406f3b4
@interim17
exit full screen button tooltip text and icon
4150484
@interim17
use getter for embedded display settings and only keep height and wid…
947e6cc 
…th cutoffs in state
@interim17
use same reset camera props for home button in both controls components
4dd3202
@interim17
embedded snippet preview with and flexbox utility higher order component
c3eaf3a
@interim17
Merge branch 'main' of https://github.com/simularium/simularium-website…
bb021d2 
… into feature/embed-controls
@meganrm @interim17
a simplified way of handling min controls (#568)
563d638 
* a simplified way of handling min controls

* simplfy scale bar bool

* Update src/containers/ViewerPanel/style.css

* Update src/containers/ViewerPanel/index.tsx

* Update src/components/PlaybackControls/index.tsx

* Update src/components/ShareTrajectoryModal/EmbedSnippetPanel.tsx

---------

Co-authored-by: Joe Heffernan <[email protected]>
@interim17
remove preview component
11f7eae
@interim17
remove unused display breakpoints state
f8873ef
@interim17
use location.origin in snippet url
c25872d
@meganrm
simplify code and rename variable
5c85426
@interim17
fix typo in tooltip
2c0b883
@interim17
remove fullscreen code and functionality from this branch
9a39382
@interim17
rename minimal controls elements and class names to be more general, …
8427f6c 
…remove references to embed
@interim17
remove optional check from footer prop in custom modal
2b59742
@interim17
use h5 tag for size header in embed snippet settings
96fd991
Base automatically changed from feature/embed-controls to main October 16, 2024 22:54
@github-actions GitHub Actions
Copy link

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements
66.4% (-0.13% 🔻)
 672/1012
🟡 Branches 65.31% 96/147
🔴 Functions
34.75% (-0.55% 🔻)
 90/259
🟡 Lines
64.86% (-0.1% 🔻)
 598/922
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🔴
... / reducer.ts
25% (-2.27% 🔻)
 0% 0%
25% (-2.27% 🔻)
🔴
... / actions.ts
52.94% (-0.39% 🔻)
 100% 0%
52.94% (-0.39% 🔻)

Test suite run success

121 tests passing in 7 suites.

Report generated by 🧪jest coverage report action from 68c5a46

@interim17 interim17 closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

embedded windows: full screen button
2 participants
@interim17 @meganrm