Feature/ant5 #626
Merged
Feature/ant5 #626
+4,299
−4,916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#609) * bump antd and typescript, and update build tools and components to work with new versions * consolidate ts.config
* bump antd and typescript, and update build tools and components to work with new versions * consolidate ts.config * replace ant-vars.less with ConfigProvider * semantic color variables names for config provider * align css var colors and theme color variables, divide light and dark theme colors * consolidate theme variables * further consolidate theme variables * styled-components.dropdown menu items (#616) * use styled-component to streamline appearance of dropdown menu items * prevent ant from overridding text color during hover/focus on dropdown items * trim unneedd props from baseStyles on dropdown items * restructure colors and theming to provide for styled-components use of themeColors * remove unused nav button drop down item variety * don't open drop downs by default * remove unused imports * make selector more specific and remove !important tag * change focus to focus-visible in selectors and typing for styled-components theme * only export semantic and component colors from theme
… into feature/ant5
* bump antd and typescript, and update build tools and components to work with new versions * consolidate ts.config * replace ant-vars.less with ConfigProvider * semantic color variables names for config provider * align css var colors and theme color variables, divide light and dark theme colors * consolidate theme variables * styling fixes for antd5 * fix record icon position * pass onClick into dropdown menu items * fix meta data panel font sizes * fix colorpicker alignment offset * remove unused commented style rule * remove unused themeConfig * bump viewer version * replace clickHandler with onClick * a few more ant migration style fixes * restore className on dropdown render div * remove unused import
* bump antd and typescript, and update build tools and components to work with new versions * consolidate ts.config * replace ant-vars.less with ConfigProvider * semantic color variables names for config provider * align css var colors and theme color variables, divide light and dark theme colors * consolidate theme variables * styling fixes for antd5 * fix record icon position * pass onClick into dropdown menu items * fix meta data panel font sizes * fix colorpicker alignment offset * remove unused commented style rule * remove unused themeConfig * apply styling fixes and use new CustomButton component to streamline button styling * bump viewer version * replace clickHandler with onClick * a few more ant migration style fixes * restore className on dropdown render div * remove duplicate import * remove unused css vars * remove unused import * use plain const for tooltip text on custom buttons * fix focus styling
Coverage report
Test suite run success137 tests passing in 8 suites. Report generated by 🧪jest coverage report action from 12dd053 |
interim17
requested review from
toloudis and
frasercl
and removed request for
a team
rugeli
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
I have clicked around on the branch and the styling looked good, everything functional as expected!
Super minor and non-blocking, but thought I'd mention it: when loading the blood plasma model, the v.1.0 tag shows up first in the title and stays grayed out the whole time.
|
Poking around the UI, I noticed a few potentially problematic visual changes:
Up to your discretion whether or not to address any one of these - I think only 1 and maybe 5 are true problems. |
|
@frasercl and @rugeli thanks for the comments
|
frasercl
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time estimate or Size
?
Huge change set, but everything has been reviewed once already.
I would say run the brunch, look for any styling issues?
Problem
Migrating ant 4 -> 5
Solution
Lot's of changes, happy to talk through previous PRs or any specific questions.
The broad overview:
antd,typescriptand made some associated config changesantdConfigProviderstyled-components, integrated it into theming and used it to style a few components that are hard to target, or require a lot of styling overrides