Fix PR commit status failing due to Codecov

sindresorhus · Apr 28, 2024 · 036b504 · 036b504
1 parent 0423ac3
commit 036b504
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -24,6 +24,9 @@ jobs:
       - run: npm install
       - run: npm test
       - uses: codecov/codecov-action@v4
+        # Codecov merges results too early, which makes it not report Windows test coverage.
+        # This makes the PR commit status fail.
+        if: matrix.os == 'ubuntu' && matrix.node-version == 20
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
           flags: '${{ matrix.os }}, node-${{ matrix.node-version }}'

diff --git a/lib/arguments/options.js b/lib/arguments/options.js
@@ -29,6 +29,7 @@ export const normalizeOptions = (filePath, rawArguments, rawOptions) => {
 
 	if (process.platform === 'win32' && basename(file, '.exe') === 'cmd') {
 		// #116
+		/* c8 ignore next */
 		commandArguments.unshift('/q');
 	}