chore: replace ts-node with tsimp #208
Merged
+23
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while back I updated the test environment to use node v20 and you said you'd prefer to use
environmentVariablesfor AVA configuration but it didn't work. I said that we could clean up the ugly config once it's fixed upstream, but it doesn't look likets-nodehas made any progress in that regard.AVA itself is now recommending
tsimpso I replacedts-nodewith that and was able to clean up our config a little bit.One benefit of using
tsimpis that it typechecks our test file as well without it needing to be referenced in ourtsconfig.json, there were a few minor issues in there that it brought up, so I addressed those.