Reduce code size #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
commented
Aug 20, 2024
| return { | ||
| [Symbol.asyncIterator]: stream[Symbol.asyncIterator].bind(stream), | ||
| }; | ||
| } |
ehmicky
commented
Aug 20, 2024
|
|
||
| export async function * combineAsyncIterables(iterable1, iterable2) { | ||
| const iterator1 = iterable1[Symbol.asyncIterator](); | ||
| const iterator2 = iterable2[Symbol.asyncIterator](); |
There was a problem hiding this comment.
Node.js streams are both iterables and iterators.
There was a problem hiding this comment.
The function name is no longer correct then.
ehmicky
force-pushed
the
reduce-code-size
branch
from
c8e2387 to
3c97ab6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some dead code.