More fixes for issues reported by Codacy

sinemakinci1 · Dec 25, 2017 · 63459e6 · 63459e6
1 parent 41f0ea0
commit 63459e6
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/tools/include_optimize.rb b/tools/include_optimize.rb
@@ -3,7 +3,7 @@
 def write_file_without_lines(source, lines, without_lines)
   out = File.new(source, 'w')
   lines.each_with_index { |v, i|
-    if without_lines.member? i then
+    if without_lines.member? i
       out.print "//", v
     else
       out.print v
@@ -16,7 +16,7 @@ def optimize(source, target)
   lines = File.new(source).readlines()
   includes = []
   lines.each_with_index { |v, i|
-    if v =~ /^#include/ then
+    if v =~ /^#include/
       # puts v
       includes << i
     end
@@ -29,7 +29,7 @@ def optimize(source, target)
     write_file_without_lines(source, lines, [i])
 
     ret = system("scons", "-u", target)
-    if ret then
+    if ret
       puts "INCUNNEEDED #{source} #{lines[i].chop}" 
       unneeded_includes << i
     end

diff --git a/tools/miniswig/create_docu.cpp b/tools/miniswig/create_docu.cpp
@@ -10,8 +10,6 @@
 void
 DocuCreator::create_docu(Namespace* ns)
 {
-    std::string fromfile = original_file != "" ? original_file : inputfile;
-
     writer.openTag("documentation");
     writer.openTag("namespace");
     writer.writeAttribute("name", ns->name);

diff --git a/tools/png_recompress.sh b/tools/png_recompress.sh
@@ -66,8 +66,6 @@ if ! type advpng > /dev/null 2>&1; then
 	exit 1
 fi
 
-TMPPATH="$$.png-recompress"
-
 echo -e "Please wait, this can take a \e[1mlong\e[0m time."
 
 dooptipng() {
-Original file line number
+Diff line change
@@ Expand Up / @@ -66,8 +66,6 @@ if ! type advpng > /dev/null 2>&1; then @@
     	exit 1
     fi
-    TMPPATH="$$.png-recompress"
     echo -e "Please wait, this can take a \e[1mlong\e[0m time."
     dooptipng() {
@@ Expand Down @@