Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing type definitions #114

Conversation

leo-schick
Copy link

Description of change

Fix a missing type definition for:

Manual QA steps

  • run tap manually

Risks

  • breaking schema validation when type changes in the future in the API

Rollback steps

  • revert this branch

@singer-bot
Copy link

Hi @leo-schick, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@singer-bot
Copy link

You did it @leo-schick!

Thank you for signing the Singer Contribution License Agreement.

@leo-schick
Copy link
Author

This has now been untouched over long time and we moved away to airbyte. Will close this PR.

@leo-schick leo-schick closed this Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants