Python client and Fusion SQL for Jobs Service #28

evieira2 · 2024-06-11T16:22:09Z

This MR implements the python client and Fusion SQL commands for Jobs Service.
Tests were also added for both the python and Fusion commands.

kesmit13

Overall, quite good. I was expecting to have to write all of this myself. :) You'll want to make sure to install pre-commit so that the checks get run. It will point out some of the things I mentioned in the review as well.

singlestoredb/management/job.py

kesmit13

There are still some issue showing up in the pre-commit checks in the Github actions, but other than that and the one change mentioned, it looks good.

singlestoredb/management/job.py

singlestoredb/management/utils.py

singlestoredb/management/job.py

kesmit13

Just a few minor things to look at.

singlestoredb/fusion/handlers/job.py

singlestoredb/tests/test_fusion.py

evieira2 self-assigned this Jun 11, 2024

evieira2 temporarily deployed to Base June 11, 2024 16:22 — with GitHub Actions Inactive

kesmit13 requested changes Jun 11, 2024

View reviewed changes

evieira2 had a problem deploying to Base June 12, 2024 09:35 — with GitHub Actions Failure

kesmit13 requested changes Jun 12, 2024

View reviewed changes

singlestoredb/management/job.py Outdated Show resolved Hide resolved

evieira2 had a problem deploying to Base June 12, 2024 16:57 — with GitHub Actions Failure

kesmit13 reviewed Jun 12, 2024

View reviewed changes

singlestoredb/management/utils.py Outdated Show resolved Hide resolved

singlestoredb/management/job.py Outdated Show resolved Hide resolved

evieira2 temporarily deployed to Base June 14, 2024 12:55 — with GitHub Actions Inactive

kesmit13 reviewed Jun 14, 2024

View reviewed changes

singlestoredb/management/job.py Outdated Show resolved Hide resolved

evieira2 temporarily deployed to Base June 14, 2024 13:39 — with GitHub Actions Inactive

evieira2 temporarily deployed to Base June 14, 2024 13:47 — with GitHub Actions Inactive

evieira2 temporarily deployed to Base June 14, 2024 14:09 — with GitHub Actions Inactive

evieira2 temporarily deployed to Base June 14, 2024 15:07 — with GitHub Actions Inactive

evieira2 temporarily deployed to Base June 14, 2024 15:12 — with GitHub Actions Inactive

evieira2 temporarily deployed to Base June 14, 2024 15:26 — with GitHub Actions Inactive

evieira2 temporarily deployed to Base June 14, 2024 15:29 — with GitHub Actions Inactive

evieira2 temporarily deployed to Base June 14, 2024 15:37 — with GitHub Actions Inactive

evieira2 temporarily deployed to Base June 14, 2024 15:47 — with GitHub Actions Inactive

evieira2 temporarily deployed to Base June 14, 2024 15:53 — with GitHub Actions Inactive

evieira2 temporarily deployed to Base June 14, 2024 16:05 — with GitHub Actions Inactive

evieira2 temporarily deployed to Base June 14, 2024 16:09 — with GitHub Actions Inactive

evieira2 temporarily deployed to Base June 14, 2024 16:12 — with GitHub Actions Inactive

evieira2 temporarily deployed to Base June 14, 2024 16:19 — with GitHub Actions Inactive

evieira2 temporarily deployed to Base June 14, 2024 17:15 — with GitHub Actions Inactive

evieira2 temporarily deployed to Base June 14, 2024 17:20 — with GitHub Actions Inactive

evieira2 temporarily deployed to Base June 14, 2024 17:23 — with GitHub Actions Inactive

evieira2 had a problem deploying to Base June 17, 2024 17:54 — with GitHub Actions Failure

evieira2 had a problem deploying to Base June 18, 2024 10:05 — with GitHub Actions Failure

evieira2 had a problem deploying to Base June 18, 2024 10:14 — with GitHub Actions Failure

evieira2 had a problem deploying to Base June 18, 2024 11:02 — with GitHub Actions Failure

debug received params

86fd96e

evieira2 temporarily deployed to Base July 29, 2024 10:47 — with GitHub Actions Inactive

change type of params

a46d835

evieira2 had a problem deploying to Base July 29, 2024 10:52 — with GitHub Actions Failure

change to key value

bbd9d7a

evieira2 had a problem deploying to Base July 29, 2024 10:55 — with GitHub Actions Failure

change to key

11ba0fe

evieira2 had a problem deploying to Base July 29, 2024 10:57 — with GitHub Actions Failure

fix fusion params

05750fe

evieira2 had a problem deploying to Base July 29, 2024 11:04 — with GitHub Actions Failure

test with runtime and params

66f1b8b

evieira2 temporarily deployed to Base July 29, 2024 11:19 — with GitHub Actions Inactive

pre commit

8f95869

evieira2 temporarily deployed to Base July 29, 2024 11:26 — with GitHub Actions Inactive

evieira2 changed the title ~~Python client and Fusion SQL for Jobs~~ Python client and Fusion SQL for Job Service Jul 29, 2024

evieira2 changed the title ~~Python client and Fusion SQL for Job Service~~ Python client and Fusion SQL for Jobs Service Jul 29, 2024

evieira2 added the feature New feature or request label Jul 29, 2024

evieira2 marked this pull request as ready for review July 29, 2024 11:28

evieira2 requested a review from kesmit13 July 29, 2024 11:29

kesmit13 reviewed Jul 29, 2024

View reviewed changes

singlestoredb/fusion/handlers/job.py Outdated Show resolved Hide resolved

singlestoredb/fusion/handlers/job.py Outdated Show resolved Hide resolved

singlestoredb/tests/test_fusion.py Show resolved Hide resolved

address MR comments

dc02ae0

evieira2 had a problem deploying to Base July 29, 2024 15:11 — with GitHub Actions Failure

evieira2 requested a review from kesmit13 July 29, 2024 15:16

kesmit13 approved these changes Jul 29, 2024

View reviewed changes

fix non existent timeout and exec interval

9702d6f

evieira2 had a problem deploying to Base July 29, 2024 16:01 — with GitHub Actions Failure

evieira2 had a problem deploying to Base July 29, 2024 16:51 — with GitHub Actions Failure

evieira2 temporarily deployed to Base July 29, 2024 18:25 — with GitHub Actions Inactive

kesmit13 merged commit 27c3a42 into main Jul 29, 2024
11 checks passed

kesmit13 deleted the evieira/MCDB-58287/python-sdk-client-for-job-service branch July 29, 2024 19:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Python client and Fusion SQL for Jobs Service #28

Python client and Fusion SQL for Jobs Service #28

evieira2 commented Jun 11, 2024 •

edited

Loading

kesmit13 left a comment

kesmit13 left a comment

kesmit13 left a comment

Python client and Fusion SQL for Jobs Service #28

Python client and Fusion SQL for Jobs Service #28

Conversation

evieira2 commented Jun 11, 2024 • edited Loading

kesmit13 left a comment

Choose a reason for hiding this comment

kesmit13 left a comment

Choose a reason for hiding this comment

kesmit13 left a comment

Choose a reason for hiding this comment

evieira2 commented Jun 11, 2024 •

edited

Loading