Remove SET NAMES usage which is no-op in SingleStore #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmishchenko-ua
changed the title
pmishchenko-ua
force-pushed
the
pavlo-fix-set-character-set
branch
from
0513ee9
to
ad9c98a
Compare
pmishchenko-ua
changed the title
pmishchenko-ua
force-pushed
the
pavlo-fix-set-character-set
branch
from
ad9c98a
to
58f9436
Compare
singlestoredb/mysql/connection.py
Outdated
| Update Connection.encoding based on charset. | ||
|
|
||
| If charset/collection are being set to utf8mb4, the corresponding global | ||
| setting must be also utf8mb4. |
There was a problem hiding this comment.
I'm just wondering about this comment, this means, that the user should change it globally manually, before calling this function, right?
There was a problem hiding this comment.
I've updated the comment, please check.
We also need @kesmit13 opinion on this behavior. Maybe we should catch the error and print a warning instead, but ignoring it could lead to weird errors I guess - e.g when the user sets charset=utf8mb4 in connect(), and then tries to write 4-byte symbols to utf8(mb3) tables
pmishchenko-ua
force-pushed
the
pavlo-fix-set-character-set
branch
from
58f9436
to
756d21c
Compare
kesmit13
reviewed
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.