Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP driver timeout bugfix #34

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

Taequn
Copy link
Contributor

@Taequn Taequn commented Sep 2, 2024

Bug description

  • The HTTP drive did not pull the correct value for the integer timeout. The cursor never passed the value to the HTTP connection, so it used default options to set the timeout to 10 seconds -- even if the connection_timeout was set to a different value.

Effect

  • Setting an appropriate timeout for the calls was impossible, so larger queries failed for Data API calls.

Fix

  • Before Cursor's _post() sends the value to the HTTP Connection's _post(), we add timeout to the passed kwargs.
  • Removed if-conditional from the HTTP Connection's _post() for redundancy. With the current setup, it always pulls the correct value. If connection_timeout is not passed, the Cursor defaults to 10 seconds, so not an issue.

Small fix

  • Added .venv to gitignore

HTTP driver did not pull the correct integer value for connection timeout. Fixed.
@kesmit13 kesmit13 merged commit ea9644b into singlestore-labs:main Sep 3, 2024
5 of 6 checks passed
@kesmit13
Copy link
Collaborator

kesmit13 commented Sep 5, 2024

This fix is now available in v1.6.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants