Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notebook functions for starting dashboard and cloud functions #35

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

nkitsaini
Copy link
Contributor

No description provided.

Copy link
Collaborator

@kesmit13 kesmit13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that the notebook package is the right place for these functions. The notebook package is for interactive environment enhancements like surfacing magical objects that proxy a workspace group or workspace that is currently selected in an interactive notebook environment. I think the better place would be in functions or maybe create a new apps package at the top level. The Python UDF server helpers are in functions which is the closest thing to this functionality, but since dashboards aren't functions I could see that not being a great name. That would mean that the app_listen_port and app_url functions would move to that package as well.

@kesmit13 kesmit13 merged commit 2de7d33 into singlestore-labs:main Sep 20, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants