-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(files): add support for Files API (personal and shared spaces) #46
feat(files): add support for Files API (personal and shared spaces) #46
Conversation
Note that I left some
|
5b2c28e
to
4401234
Compare
6942115
to
2f0a82d
Compare
4401234
to
6ed1217
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think leaving the unsupported methods in the API and just raising errors is ok. It makes it easier for the user to determine what's wrong if they attempt to use it, although it does make those show up in auto-complete like they are supported. I think the way you have it implemented is the lesser of evils.
2f0a82d
to
9f2fc6d
Compare
6ed1217
to
43b24d4
Compare
We have recently updated the
Management API
to include new endpoints for managing files in personal and shared spaces. Thus, we would like to update thePython SDK
to support these resources as well.Since the methods for stage files and personal/shared space files are quite similar, we would like to refactor the
Python SDK
by introducing an abstract class calledFileLocation
. This class will be implemented byStage
andFileSpace
, which will be used to interact with the Files API for personal and shared files.This PR introduces the
FilesManager
andFileSpace
classes, allowing us to manage files in personal and shared spaces.Note that this PR depends on #45 and only affects the
Python SDK
. To keep the PRs smaller, I will include theFusion SQL
changes related to the Files API in a separate PR.cc: @ricardoasmarques @kanitsharma