-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dsidirop/tasks/iban 00019 add support for exotic countries #20
Dsidirop/tasks/iban 00019 add support for exotic countries #20
Conversation
… to test against the exotic countries b = National bank code s = Branch code c = Account number Central African Republic 27 23n CFkk nnnn nnnn nnnn nnnn nnnn nnn [CF 42 20001000010120069700160] Chad 27 23n TDkk nnnn nnnn nnnn nnnn nnnn nnn [TD 89 60002000010271091600153] Comoros 27 23n KMkk nnnn nnnn nnnn nnnn nnnn nnn [KM 46 00005000010010904400137] Congo, Republic of the 27 23n CGkk nnnn nnnn nnnn nnnn nnnn nnn [CG 39 30011000101013451300019] Côte d'Ivoire 28 1a, 23n CIkk annn nnnn nnnn nnnn nnnn nnnn [CI 77 A 12312341234123412341234] Djibouti 27 23n DJkk nnnn nnnn nnnn nnnn nnnn nnn [DJ 21 10002010010409943020008] Equatorial Guinea 27 23n GQkk nnnn nnnn nnnn nnnn nnnn nnn [GQ 70 50002001003715228190196] Gabon 27 23n GAkk nnnn nnnn nnnn nnnn nnnn nnn [GA 21 40021010032001890020126] Guinea-Bissau 25 2c, 19n GWkk ccnn nnnn nnnn nnnn nnnn n [GW 04 GW1430010181800637601] Honduras 28 4a, 20n HNkk aaaa nnnn nnnn nnnn nnnn nnnn [HN 54 PISA00000000000000123124] Morocco 28 24n MAkk nnnn nnnn nnnn nnnn nnnn nnnn [MA 64 011519000001205000534921] Nicaragua 32 4a, 24n NIkk aaaa nnnn nnnn nnnn nnnn nnnn nnnn [NI 92 BAMC000000000000000003123123] Niger 28 2a, 22n NEkk aann nnnn nnnn nnnn nnnn nnnn [NE 58 NE0380100100130305000268] Togo 28 2a, 22n TGkk aann nnnn nnnn nnnn nnnn nnnn [TG 53 TG0090604310346500400070] Libya 25 21n LYkk bbbs sscc cccc cccc cccc c [LY 83 002048000020100120361]
…Central African Republic" IBANs
…Cote Divoire" IBANs
…Djibouti" / "Equatorial Guinea" / "Gabon" IBANs
…Honduras" / "Guinea Bissau" IBANs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I double checked with the BBAN definitions on the internet and it is ok, good job !
Cool! Thanks for tuning in. Feel free to copy-paste links to the resources that mention the specs you checked the pull-request against. I'm saying this because I had to hunt "high and low" to find the specs in various websites + wikipedia so if you have a resource which contains all specs for all ibans in a single place I would very much appreciate it! Thanks again and stay safe! |
Hi, here is the place where I found the specs: https://en.wikipedia.org/wiki/International_Bank_Account_Number |
Any issues with this PR, can we have this merged? |
Yeah sure, I see no problem merging this PR |
Can someone approve this PR? |
I cross checked with the BBAN definitions and it looks good. Thanks @ShrujanKotturi |
I love conflicting pulls... |
#19