Rename RawClass property names #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the JSON files (and also overrides) more readable; performance should not be affected since the files are gzipped in transit.
dtemkin1
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
this all looks good to me! something to work on in the future might be adding parameter/return type hints to the python scraper (eg. using TypedDicts for dict results), or maybe later find some way of sharing types between the frontend and backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40 (following up on #37). This makes the JSON files (and also overrides) more readable; performance should not be affected since the files are gzipped in transit.
I tried my best to be exhaustive in renaming things, and things seem to generally work, but I'd appreciate another pair of eyes to make sure that everything works properly (both in the current semester and in previous semesters).