-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reset values and access modifiers from the SDK #6
Conversation
Note that unlike the TZC_NSEC registers these registers are not marked as read only. Parsed from https://github.com/pine64/bl_iot_sdk/blob/4c2e1c6dbbb44fd67ba680415e708a409164c425/components/bl602/bl602_std/bl602_std/Device/Bouffalo/BL602/Peripherals/tzc_sec_reg.h#L182
Reset and access values were incorrectly applied to the wrong registers. `se_trng_0_rosc_en` is called `se_trng_0_rosc_dis` in the SDK and has been changed (same bit location in the same register).
I've rechecked every value and came up with some misapplied reset values and access modifiers, as well as some registers in GLB that I missed because I assumed that I had done them in PR #4. The |
Fixed merge conflict from PR #5. |
Build fails due to warnings
Until these are fixed the return code of |
Ignoring the return code from program using GHA is painful. |
Couldn't you do something like #! /usr/bin/env bash
./SVDConv soc602_reg.svd
if [ $? == 1 ]; then
exit 0
fi Since return code 0 is nothing, 1 is warning and 2 is error, only capturing 1 will still fail on errors. |
Yep, that's exactly what we need to do |
Ah, I see what you meant in your original comment now, Github Actions is indeed a little annoying to use at times. |
Corrected duplicated |
This PR adds reset values and access modifiers directly from the SDK.
The struct fields (specific structs in each commit) parsed looked like
There are some fields with access values as
w1c
andw1p
, although I do not know how to represent this in the SVD so they have not been included. In the future those modifiers should also be added.