svd: Put the XML declaration at the very top #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the XML specification[1], the XML declaration (XMLDecl) is allowed *only* as the very first production in the prolog, which in turn can appear only as the very first production in the document. This means it must come before all comments or the XML file is invalid. Java and Python XML parsers fail[2] on documents like this one which violate that part of the spec. Move the declaration up so our SVD is valid XML. [1] https://www.w3.org/TR/xml/#NT-prolog [2] https://stackoverflow.com/a/19898942/6568778
|
This obviously correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the XML specification, the XML declaration (XMLDecl) is allowed only as the very first production in the prolog, which in turn can appear only as the very first production in the document. This means it must come before all comments or the XML file is invalid. Java and Python XML parsers fail on documents like this one which violate that part of the spec.
Move the declaration up so our SVD is valid XML.