You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
If a newly added token pair's oracle returns a price of 0 inside of PriceOracle.addTokenPair, then that token pair will never be useable going forward.
To Reproduce
Steps to reproduce the behavior:
Call PriceOracle.addTokenPair using an oracle that returns a price of 0.
Expected behavior
I expect any call to PriceOracle.addTokenPair will not render that token pair useless
Additional context
To fix this, we should require a check in PriceOracle.addTokenPair to make sure we never set a price of 0, or else we'll never be able to use that token pair again.
The text was updated successfully, but these errors were encountered:
Describe the bug
If a newly added token pair's oracle returns a price of
0
inside ofPriceOracle.addTokenPair
, then that token pair will never be useable going forward.To Reproduce
Steps to reproduce the behavior:
0
.Expected behavior
I expect any call to PriceOracle.addTokenPair will not render that token pair useless
Additional context
To fix this, we should require a check in PriceOracle.addTokenPair to make sure we never set a price of 0, or else we'll never be able to use that token pair again.
The text was updated successfully, but these errors were encountered: