Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure token pairs start with valid price #84

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Ensure token pairs start with valid price #84

merged 1 commit into from
Sep 23, 2021

Conversation

siren-tamer
Copy link
Contributor

Fixes issue #67 .

When adding a new token pair, the solidity code will now ensure it starts with a valid price. If the oracle returns 0 it will revert the tx.

Unit test added to verify.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 1263417845

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 75.695%
Files with Coverage Reduction New Missed Lines %
contracts/series/PriceOracle.sol 4 90.0%
Totals Coverage Status
Change from base Build 1262734649: 0.05%
Covered Lines: 872
Relevant Lines: 1049
💛 - Coveralls

@siren-tamer siren-tamer merged commit d090b92 into master Sep 23, 2021
@siren-tamer siren-tamer deleted the issue-67 branch September 23, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MysticDakra MysticDakra MysticDakra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siren-tamer @coveralls @MysticDakra