Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Tally data provider addition #2180

Merged
merged 4 commits into from
Sep 15, 2023
Merged

feat: Tally data provider addition #2180

merged 4 commits into from
Sep 15, 2023

Conversation

yum0e
Copy link
Collaborator

@yum0e yum0e commented Sep 15, 2023 •
edited
Loading

Context

Addition of the Tally Provider that exposes three methods:

  • getProposalVoters: to know all voters of a specific proposal on Tally
  • getGovernanceVoters: to know all voters of a specific DAO on Tally
  • getGovernanceProposers: to know all proposals proposers of a specific DAO on Tally

Fixes #1984

todo

  • implemented Tally Data Provider
  • added interface for Factory usage
  • updated CI with TALLY_API_KEY env variable

Thanks a lot to @3scava1i3r for tackling this issue!

@yum0e yum0e temporarily deployed to staging September 15, 2023 09:21 — with GitHub Actions Inactive
@yum0e yum0e temporarily deployed to staging September 15, 2023 10:37 — with GitHub Actions Inactive
@yum0e yum0e temporarily deployed to staging September 15, 2023 11:51 — with GitHub Actions Inactive
@yum0e yum0e merged commit e99900c into main Sep 15, 2023
8 checks passed
@yum0e yum0e deleted the data-provider-tally branch September 15, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xbulma 0xbulma 0xbulma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Proposal] Integrate Tally as Data Provider
3 participants
@yum0e @0xbulma @3scava1i3r